Re: [libvirt PATCH v8 26/37] qemu: improve error handling when restarting nbdkit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 31, 2023 at 16:40:06 -0500, Jonathon Jongsma wrote:
> Change the return value for qemuNbdkitProcessRestart() and
> qemuNbdkitStorageSourceManageProcess() to return an error status. The
> main effect of this change is that when libvirt starts up and reconnects
> to an already-running domain with an nbdkit-backed disk, it will return
> an error if it fails to restart any nbdkit processes that are not found
> to be running or if it fails to monitor any running nbdkit processes.
> These failures will result in the domain being killed.

I don't quite understand why this is a separate patch, but ...

> Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c  |  3 ++-
>  src/qemu/qemu_nbdkit.c  | 34 ++++++++++++++++------------------
>  src/qemu/qemu_nbdkit.h  |  4 ++--
>  src/qemu/qemu_process.c |  6 ++++--
>  4 files changed, 24 insertions(+), 23 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux