On Thu, Aug 24, 2023 at 05:44:32PM +0200, Peter Krempa wrote: > On Thu, Aug 24, 2023 at 17:29:49 +0200, Pavel Hrdina wrote: > > Now that deleting and reverting external snapshots is implemented we can > > report that in capabilities so management applications can use that > > information and start using external snapshots. > > > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > --- > > docs/formatcaps.rst | 6 ++++++ > > src/conf/capabilities.c | 1 + > > src/conf/capabilities.h | 1 + > > src/conf/schemas/capability.rng | 5 +++++ > > src/qemu/qemu_capabilities.c | 1 + > > tests/qemucaps2xmloutdata/caps.aarch64+hvf.xml | 1 + > > tests/qemucaps2xmloutdata/caps.aarch64.xml | 1 + > > tests/qemucaps2xmloutdata/caps.ppc.xml | 1 + > > tests/qemucaps2xmloutdata/caps.ppc64.xml | 1 + > > tests/qemucaps2xmloutdata/caps.riscv64.xml | 1 + > > tests/qemucaps2xmloutdata/caps.s390x.xml | 1 + > > tests/qemucaps2xmloutdata/caps.sparc.xml | 1 + > > tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml | 1 + > > tests/qemucaps2xmloutdata/caps.x86_64.xml | 1 + > > 14 files changed, 23 insertions(+) > > > > diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst > > index f7e5342654..0e056914b8 100644 > > --- a/docs/formatcaps.rst > > +++ b/docs/formatcaps.rst > > @@ -134,6 +134,11 @@ The ``<guest/>`` element will typically wrap up the following elements: > > external disk snapshots are supported. If absent, external snapshots may > > still be supported, but it requires attempting the API and checking for an > > error to find out for sure. :since:`Since 1.2.3` > > + ``externalSnapshot`` > > + If this element is present, the hypervisor supports creating, deleting and > > + reverting external snapshots including memory state and management > > + applications can switch from internal snapshots to external snapshots. > > + :since:`Since 9.7.0` > > This implies that 'creation' of external snapshots is also included in > the "Sice 9.7.0". Reword it such that you explicitly mention that > creation of external snapshots is a long-existing feature. > > You can also entirely omit 'creation' from the text as it's covered by > 'disksnapshot' above. Yeah the fact the feature name is `disksnapshot` is a bit unfortunate and it doesn't mention that only creation is supported if that feature is available. I'll reword it and post v2. Thanks, Pavel
Attachment:
signature.asc
Description: PGP signature
