On Wed, Aug 23, 2023 at 11:38:17AM +0200, Erik Skultety wrote: > On Mon, Aug 21, 2023 at 05:17:06AM -0700, Andrea Bolognani wrote: > > On Mon, Feb 06, 2023 at 02:53:06PM +0100, Erik Skultety wrote: > > > -meson setup build --werror -Dsystem=true $MESON_OPTS $MESON_ARGS || \ > > > +MESON_ARGS="$MESON_ARGS $MESON_OPTS" > > > + > > > +meson setup build --werror -Dsystem=true $MESON_ARGS || \ > > > > This has inverted the priority of the two lists of arguments. > > > > Before the change, an option (e.g. -Dfoo=enabled) could be added to > > $MESON_ARGS at the job level and it would override the same option > > (e.g. -Dfoo=disabled) defined as part of $MESON_OPTS in the container > > image. Now the option in the container image will always take > > precedence, which is undesirable. > > Good points. However, I'm already close to proposing something vastly different > from this, dropping most of these variables as they are to make the local > executions pretty much >95% compatible to what happens in GitLab and overriding > these shell variables simply isn't part of it because it only makes sense right > now, but I think with the changes I have it'll only make sense in interactive > container shell sessions in which case it's left to the developer to set and > pass the right options IMO. This all sounds good, but in the meantime the feature is not working as intended. I've posted a quick fix here: https://listman.redhat.com/archives/libvir-list/2023-August/241402.html -- Andrea Bolognani / Red Hat / Virtualization
