Re: [PATCH 11/31] qemu: capabilities: Don't make callers check return of virQEMUCapsNew(Binary)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Friday in 2023, Peter Krempa wrote:
The allocation of the object itself can't fail. What can fail is the
creation of the class on a programmign error. Rather than punting the

*programming

error up the stack abort() directly on the first occurence as the error
can't be fixed during runtime.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
src/qemu/qemu_capabilities.c     | 20 ++++----------------
src/qemu/qemu_domain.c           |  3 +--
tests/cputest.c                  |  3 +--
tests/qemucapabilitiestest.c     |  6 +++---
tests/qemucaps2xmltest.c         |  3 +--
tests/qemuhotplugtest.c          |  3 +--
tests/qemumemlocktest.c          |  5 +----
tests/securityselinuxlabeltest.c |  3 +--
tests/testutilsqemu.c            |  8 +++-----
9 files changed, 16 insertions(+), 38 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux