Re: [libvirt PATCH 00/14] tests: Improve QEMU driver config handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 06, 2023 at 04:56:39AM -0800, Andrea Bolognani wrote:
On Mon, Mar 06, 2023 at 01:49:50PM +0100, Martin Kletzander wrote:
On Mon, Mar 06, 2023 at 04:41:28AM -0800, Andrea Bolognani wrote:
> A test called "controller-order" is definitely unrelated to SPICE
> TLS. For "q35-virt-manager-basic", I guess you could argue either
> way? It feels more unrelated than related to me.

No, of course, that's not the point, it is not trying to test spice with
tls.  But because the spice-tls tests are not next to each other (and
would probably make a bigger mess in the order anyway) it *feels*
arbitrary when the spiceTLS is set and unset, it's fine the way it is.

Gotcha :)

> Or were you referring to the various VIR_FREE(*TLSx509secretUUID)
> calls that I'm adding? Because that was indeed intended to be a
> separate commit, which I seem to have accidentally squashed in O:-)

Posted that change as a separate patch, as it was originally
intended, here:

 https://listman.redhat.com/archives/libvir-list/2023-March/238448.html

Please let me know if I can use that instead of the combined version
from v1 that you ACKed.


Oh, sure, it can be a separate commit, feel free to use my

Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

on that too.

--
Andrea Bolognani / Red Hat / Virtualization

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux