Re: [libvirt PATCH v4 09/31] qemu: query nbdkit module dir from binary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2023 at 16:03:03 -0600, Jonathon Jongsma wrote:
> Rather than having NBDKIT_MODDIR as a build configuration option, query
> the nbdkit binary for the location to these directories. nbdkit provides
> a --dump-config optiont that outputs this information and can be easily
> parsed. We can also get the version from this output rather than
> executing `nbdkit --version` separately.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
> ---
>  meson.build            |  6 ----
>  meson_options.txt      |  1 -
>  src/qemu/qemu_nbdkit.c | 75 +++++++++++++++++++++++++++++++++---------
>  3 files changed, 60 insertions(+), 22 deletions(-)

You can use:

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

On the detection code changes, wherever you place them.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux