Re: [libvirt PATCH v4 09/31] qemu: query nbdkit module dir from binary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2023 at 16:03:03 -0600, Jonathon Jongsma wrote:
> Rather than having NBDKIT_MODDIR as a build configuration option, query
> the nbdkit binary for the location to these directories. nbdkit provides
> a --dump-config optiont that outputs this information and can be easily
> parsed. We can also get the version from this output rather than
> executing `nbdkit --version` separately.

This patch looks more like a fixup to the patches adding the stuff this
is removing. If you want to keep the addition of the probing code
separately it's okay, but I don't like adding the build time config just
to delete them 3 patches later.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux