On Tue, Dec 13, 2022 at 02:07:12AM -0800, Andrea Bolognani wrote:
> On Tue, Dec 13, 2022 at 09:55:19AM +0000, Daniel P. Berrangé wrote:
> > On Mon, Dec 12, 2022 at 03:39:44PM -0700, Jim Fehlig wrote:
> > > > > +%files daemon-plugin-lockd
> > > > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver
> > > >
> > > > I believe this directory belongs to either the libvirt-daemon-lock
> > > > package (more likely) or possibly the libvirt-daemon-common package.
> > >
> > > Yep, I think libvirt-daemon-lock is correct. Thanks a lot for the review and
> > > comments!
> >
> > libvirt-daemon-lock isn't the right place, as that's the home
> > for virtlockd.
> >
> > This directory is what contains either lockd.so or sanlock.so,
> > which are both client side plugins for other daemons.
>
> virlockd is the one that's going to load the plugins, so I don't
> think it's necessarily wrong for its package to own the directory.
No it is not. virtqemud locks the lockd.so plugin, as lockd.so
provides the client impl to talk to virtlockd. Think of lockd.so
as being equiv of libvirt.so
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
