On Tue, Dec 13, 2022 at 09:55:19AM +0000, Daniel P. Berrangé wrote:
> On Mon, Dec 12, 2022 at 03:39:44PM -0700, Jim Fehlig wrote:
> > > > +%files daemon-plugin-lockd
> > > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver
> > >
> > > I believe this directory belongs to either the libvirt-daemon-lock
> > > package (more likely) or possibly the libvirt-daemon-common package.
> >
> > Yep, I think libvirt-daemon-lock is correct. Thanks a lot for the review and
> > comments!
>
> libvirt-daemon-lock isn't the right place, as that's the home
> for virtlockd.
>
> This directory is what contains either lockd.so or sanlock.so,
> which are both client side plugins for other daemons.
virlockd is the one that's going to load the plugins, so I don't
think it's necessarily wrong for its package to own the directory.
> It could go in libvirt-daemon-common, or it can just be
> duplicated in both the daemon-plugin-lockd and daemon-lock-sanlock
> packages - its fine to have multiple RPMs own the same dir, as long
> as permissions/user/group match
libvirt-daemon-common sounds good. It is already going to own the
connection-driver directory. But libvirt-daemon-lock will need a
dependency on it, which otherwise it wouldn't have.
--
Andrea Bolognani / Red Hat / Virtualization
