Re: [libvirt PATCH v3 01/18] schema: allow 'ssh' as a protocol for network disks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/7/22 5:15 AM, Peter Krempa wrote:
On Tue, Nov 15, 2022 at 12:07:18 +0100, Ján Tomko wrote:
On a Thursday in 2022, Jonathon Jongsma wrote:
There was support in the code for parsing protocol='ssh' on network disk
sources, but it was not present in the xml schema. Add this to the
schema and mention it in the documentation.

Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
---
src/conf/schemas/domaincommon.rng             |  1 +
.../disk-network-ssh.x86_64-latest.args       | 36 +++++++++++++++++++
tests/qemuxml2argvdata/disk-network-ssh.xml   | 31 ++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
4 files changed, 69 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-network-ssh.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-network-ssh.xml


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Note that my comments from the v2 review were not addressed.



Well, I did address your comments in a way. I removed the mention of the 'ssh' protocol type from the documentation of the domain xml in order to not encourage people to try to use it. But if you want me to leave it in the documentation but add a warning, I can do that instead.

Jonathon




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux