On Tue, Nov 15, 2022 at 12:07:18 +0100, Ján Tomko wrote: > On a Thursday in 2022, Jonathon Jongsma wrote: > > There was support in the code for parsing protocol='ssh' on network disk > > sources, but it was not present in the xml schema. Add this to the > > schema and mention it in the documentation. > > > > Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > > --- > > src/conf/schemas/domaincommon.rng | 1 + > > .../disk-network-ssh.x86_64-latest.args | 36 +++++++++++++++++++ > > tests/qemuxml2argvdata/disk-network-ssh.xml | 31 ++++++++++++++++ > > tests/qemuxml2argvtest.c | 1 + > > 4 files changed, 69 insertions(+) > > create mode 100644 tests/qemuxml2argvdata/disk-network-ssh.x86_64-latest.args > > create mode 100644 tests/qemuxml2argvdata/disk-network-ssh.xml > > > > Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Note that my comments from the v2 review were not addressed.
