On Mon, Jun 13, 2022 at 10:15 AM Rohit Kumar <rohit.kumar3@xxxxxxxxxxx> wrote: > > > On 03/06/22 5:21 pm, Peter Krempa wrote: > > On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote: > >> On 17/05/22 8:55 pm, Peter Krempa wrote: > >>> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote: > >>>> Ping. > >>>> > >>>> Hi Peter, > >>>> can you please take a look on this v3 patchset ? > >>> Yes, don't worry and please be patient. There are some intricacies that > >>> are not properly handled by your series and rather than me using you as > >>> a email operated remote editor I'll have a proper look and fix certain > >>> aspects. > >> > >> Peter, > >> Thanks a lot for taking the time to look at patches and volunteering to > >> fix the bits that are not handled properly in this patch. Do let me know > >> if there is anything I can assist you with, I would be happy to be a part > >> on this. > > Hi Rohit, > > > > I've finally managed to make all adjustments I'd be proposing. I've > > posted the series: > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__listman.redhat.com_archives_libvir-2Dlist_2022-2DJune_232167.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=kKHpBT0wOfZSxDEjkUfvIo6xT7S1-GPz0KJGNmzkk0o&e= > > > > alternatively you can fetch it at: > > > > git fetch https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_pipo.sk_libvirt.git&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=hA8g0qVcO6Et2emoksZNeXyQf_p5k9ik72d4bnOPWyw&e= network-nvram2 > > > > Please give it a try and test all your cases. I've ran out of time to > > give it testing this week. Ideally also test the old cases. > > > Hi Peter, > > Thanks for the working on this. > > I have tested the v4 patchset with tests related to UEFI and secureboot. > All tests are passing. > > > > > You can now also provide a 'NEWS.rst' entry I've stripped out of the > > original series as we require that changes to 'NEWS.rst' are done > > separately from anything else. > > Sure. I will send a patch soon to update 'NEWS.rst'. When you send updated patchset with NEWS.rst, please add Tested-by: Rohit Kumar <rohit.kumar3@xxxxxxxxxxx> tag to the patches.
