On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote: > > On 17/05/22 8:55 pm, Peter Krempa wrote: > > On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote: > > > Ping. > > > > > > Hi Peter, > > > can you please take a look on this v3 patchset ? > > Yes, don't worry and please be patient. There are some intricacies that > > are not properly handled by your series and rather than me using you as > > a email operated remote editor I'll have a proper look and fix certain > > aspects. > > > Peter, > Thanks a lot for taking the time to look at patches and volunteering to > fix the bits that are not handled properly in this patch. Do let me know > if there is anything I can assist you with, I would be happy to be a part > on this. Hi Rohit, I've finally managed to make all adjustments I'd be proposing. I've posted the series: https://listman.redhat.com/archives/libvir-list/2022-June/232167.html alternatively you can fetch it at: git fetch https://gitlab.com/pipo.sk/libvirt.git network-nvram2 Please give it a try and test all your cases. I've ran out of time to give it testing this week. Ideally also test the old cases. You can now also provide a 'NEWS.rst' entry I've stripped out of the original series as we require that changes to 'NEWS.rst' are done separately from anything else.
