Re: [PATCH v4 07/19] docstring: enums: libvirt: Add 'Since version' metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 22, 2022 at 09:23:32PM +0200, Victor Toso wrote:
>      VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS = (1 << 0), /* List all descendants,
>                                                          not just children, when
>                                                          listing a snapshot */
>
> -    /* For historical reasons, groups do not use contiguous bits.  */
> +    /* For historical reasons, groups do not use contiguous bits. (Since: v0.9.7)  */

This second comment gets parsed as if it was a continuation of the
previous one, but it shouldn't. It's just one of those in-between
comments that confuse apibuild.py. I'll get rid of it and put the
Since tag where it belongs.

>       * that is not available.  When servicing the page fault, if disk IO is
>       * required, it is considered a major fault.  If not, it is a minor fault.
>       * These are expressed as the number of faults that have occurred.
> +     *
> +     * Since: v0.7.5
> +     *
>       */
>      VIR_DOMAIN_MEMORY_STAT_MAJOR_FAULT     = 2,

There are a few cases where an empty line sneaked in. I should have
fixed all of them before pushing.

>      VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA = (1 << 4), /* If last use of domain,
>                                                              then also remove any
>                                                              checkpoint metadata */
>
> -    /* Future undefine control flags should come here. */
> +    /* Future undefine control flags should come here. (Since: v5.6.0) */

Here's another instance of the issue mentioned earlier.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux