Hi, The 4th is coming! v3: https://listman.redhat.com/archives/libvir-list/2022-April/230200.html v2: https://listman.redhat.com/archives/libvir-list/2022-April/230097.html v1: https://listman.redhat.com/archives/libvir-list/2022-April/229881.html I tried to be more careful this time in regards to the patch flow. - The first 4 patches are related to wrong versions introduced in https://gitlab.com/libvirt/libvirt/-/commit/034432e47b Each commit log points out the error I did in v3 and fixes it. If you rather squash them, feel free. - 05/19 "remove comments between enum values" are following Andrea and Peter's suggestion that this should be fixed before adding the version tags: https://listman.redhat.com/archives/libvir-list/2022-April/230304.html - 06/19 "avoid sc_prohibit_nonreentrant in a comment" is the workaround proposed by Peter to avoid syntax-check failure https://listman.redhat.com/archives/libvir-list/2022-April/230238.html - I have set the virAdm exported types to be minimum = v2.0.0. This is for all related types of libvirt-admin: * 08/19 for enums; * 09/19 for macros; * 10/19 for typedefs; * 12/19 for functions; - For exported version of functions, the syms file are the source of truth apart from 4 functions (Peter) https://listman.redhat.com/archives/libvir-list/2022-April/230236.html - Variable's comments are now properly sanitized (Andrea) https://listman.redhat.com/archives/libvir-list/2022-April/230352.html - Removed an extra line in the block of comments (Andrea) https://listman.redhat.com/archives/libvir-list/2022-April/230291.html The CI run for this series: https://gitlab.com/victortoso/libvirt/-/pipelines/522757286 Have a great weekend, Victor Victor Toso (19): docstring: typedef: fix version of virConnectListAllStoragePoolsFlags docstring: typedef: fix version of virDomainDeviceModifyFlags docstring: typedef: fix version of virDomainMemoryModFlags docstring: typedef: fix version of virDomainVcpuFlags docstring: remove comments between enum values docstring: avoid sc_prohibit_nonreentrant in a comment docstring: enums: libvirt: Add 'Since version' metadata docstring: enums: admin: Add 'Since version' metadata docstring: macros: admin: Add 'Since version' metadata docstring: typedef: admin:: Add 'Since version' metadata docstring: function: libvirt: Add 'Since version' metadata docstring: function: admin: Add 'Since version' metadata scripts: apibuild: parse 'Since' version for enums scripts: apibuild: fix parsing block comments from typedef enum scripts: apibuild: parse 'Since' for typedefs scripts: apibuild: parse 'Since' for macros scripts: apibuild: parse 'Since' for functions scripts: apibuild: factor out comment cleaning scripts: apibuild: add parsing variable's comments include/libvirt/libvirt-admin.h | 67 +- include/libvirt/libvirt-domain-checkpoint.h | 28 +- include/libvirt/libvirt-domain-snapshot.h | 60 +- include/libvirt/libvirt-domain.h | 1260 +++++++++++-------- include/libvirt/libvirt-event.h | 24 +- include/libvirt/libvirt-host.h | 62 +- include/libvirt/libvirt-interface.h | 8 +- include/libvirt/libvirt-network.h | 92 +- include/libvirt/libvirt-nodedev.h | 70 +- include/libvirt/libvirt-nwfilter.h | 4 +- include/libvirt/libvirt-secret.h | 40 +- include/libvirt/libvirt-storage.h | 173 +-- include/libvirt/libvirt-stream.h | 24 +- include/libvirt/virterror.h | 408 +++--- scripts/apibuild.py | 163 ++- src/admin/libvirt-admin.c | 62 + src/libvirt-domain-checkpoint.c | 24 + src/libvirt-domain-snapshot.c | 42 + src/libvirt-domain.c | 371 +++++- src/libvirt-host.c | 68 + src/libvirt-interface.c | 42 + src/libvirt-network.c | 89 ++ src/libvirt-nodedev.c | 54 + src/libvirt-nwfilter.c | 48 + src/libvirt-secret.c | 40 + src/libvirt-storage.c | 114 ++ src/libvirt-stream.c | 34 + src/libvirt.c | 12 + src/util/virerror.c | 30 + src/util/virevent.c | 18 + 30 files changed, 2497 insertions(+), 1034 deletions(-) -- 2.35.1