On Mon, Mar 28, 2022 at 04:21:15PM +0200, Michal Prívozník wrote: > On 3/25/22 17:03, John Levon wrote: > > The callback ID can be zero, not necessarily positive; correct the > > comment to reflect this. > > > > Signed-off-by: John Levon <levon@xxxxxxxxxxxxxxxxx> > > --- > > src/libvirt-domain.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c > > index a197618673..53efb60406 100644 > > --- a/src/libvirt-domain.c > > +++ b/src/libvirt-domain.c > > @@ -9486,7 +9486,7 @@ virDomainMigrateStartPostCopy(virDomainPtr domain, > > * The reference can be released once the object is no longer required > > * by calling virDomainFree(). > > * > > - * The return value from this method is a positive integer identifier > > + * The return value from this method is a non-negative integer identifier > > * for the callback. To unregister a callback, this callback ID should > > * be passed to the virConnectDomainEventDeregisterAny() method. > > * > > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > and pushed. Congratulations on your first libvirt contribution. ...in a little while. John used to help maintain us libvirt on Solaris back in the very early days when we were Xen focused and KVM was barely starting to get off the ground :-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
