Re: [PATCH] virConnectDomainEventRegisterAny: correct docs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/25/22 17:03, John Levon wrote:
> The callback ID can be zero, not necessarily positive; correct the
> comment to reflect this.
> 
> Signed-off-by: John Levon <levon@xxxxxxxxxxxxxxxxx>
> ---
>  src/libvirt-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index a197618673..53efb60406 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -9486,7 +9486,7 @@ virDomainMigrateStartPostCopy(virDomainPtr domain,
>   * The reference can be released once the object is no longer required
>   * by calling virDomainFree().
>   *
> - * The return value from this method is a positive integer identifier
> + * The return value from this method is a non-negative integer identifier
>   * for the callback. To unregister a callback, this callback ID should
>   * be passed to the virConnectDomainEventDeregisterAny() method.
>   *

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

and pushed. Congratulations on your first libvirt contribution.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux