Re: [PATCH] libxl: remove redundant variable from libxlDomainJobObj

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/28/22 11:49, Kristina Hanicova wrote:
> It makes no sense to have 'started' variable in the
> libxlDomainJobObj as the same one is already in virDomainJobData,
> but never used.
> 
> Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx>
> ---
>  src/libxl/libxl_domain.c | 10 +++++-----
>  src/libxl/libxl_domain.h |  1 -
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

and pushed.

Another supporting argument is that even libxlDomainObjResetJob() does
not reset the job->started. After this patch, maybe it should reset
job->current?

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux