Re: [PATCH 0/8] driver: Fix handling of driver feature flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 16, 2022 at 04:41:04PM +0100, Peter Krempa wrote:
> In a review of code using FD passing I was asked to add the check, so I
> wanted to see how it works and found a few issues.
>
> Peter Krempa (8):
>   driver: Introduce global driver feature flag handling function
>   virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE
>   virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_PROGRAM_KEEPALIVE
>   virDriverFeatureIsGlobal: Handle
>     VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK
>   virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_TYPED_PARAM_STRING
>   virDriverFeatureIsGlobal: Handle
>     VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER
>   virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING
>   virDomainCreate(XML)WithFiles: Add check for
>     VIR_DRV_FEATURE_FD_PASSING

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

I've also posted a small follow-up patch:

  https://listman.redhat.com/archives/libvir-list/2022-February/msg00656.html

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux