Re: [PATCH 0/8] driver: Fix handling of driver feature flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Wednesday in 2022, Peter Krempa wrote:
In a review of code using FD passing I was asked to add the check, so I
wanted to see how it works and found a few issues.

Peter Krempa (8):
 driver: Introduce global driver feature flag handling function
 virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE
 virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_PROGRAM_KEEPALIVE
 virDriverFeatureIsGlobal: Handle
   VIR_DRV_FEATURE_REMOTE_(CLOSE|EVENT)_CALLBACK
 virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_TYPED_PARAM_STRING
 virDriverFeatureIsGlobal: Handle
   VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER
 virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING
 virDomainCreate(XML)WithFiles: Add check for
   VIR_DRV_FEATURE_FD_PASSING

src/ch/ch_driver.c          |  5 +++
src/driver.c                | 65 +++++++++++++++++++++++++++++++++++++
src/driver.h                |  3 ++
src/esx/esx_driver.c        |  4 +++
src/libvirt-domain.c        | 24 ++++++++++++++
src/libvirt_private.syms    |  1 +
src/libxl/libxl_driver.c    |  5 +++
src/lxc/lxc_driver.c        |  5 +++
src/network/bridge_driver.c |  5 +++
src/openvz/openvz_driver.c  |  5 +++
src/qemu/qemu_driver.c      |  5 +++
src/test/test_driver.c      |  5 +++
src/vz/vz_driver.c          |  5 +++
13 files changed, 137 insertions(+)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux