On 1/20/22 18:23, Ani Sinha wrote: > > > On Thu, Jan 20, 2022 at 21:29 Michal Prívozník <mprivozn@xxxxxxxxxx > <mailto:mprivozn@xxxxxxxxxx>> wrote: > > On 1/20/22 16:48, Ani Sinha wrote: > > > > > > > > > AKA kicking the can one more time 🙃 > > Well, I should have been more careful and not merge the patch in the > first place. Changing API behavior is something we should never do. > > Looking at the code closer, it looks like all callers of this function > would need to ignore the reported error so that their behavior is not > changed. At this point, does it make sense to report an error in the > function? > > > The callers can decide what do with the error raised by the function. We > should not write functions that cannot fail. > But that's not what the commit does, is it. It changed some public APIs from best effort to fail early. Therefore, it was reverted until we can come up with proper fix. Libvirt's promise and value is in stability of its APIs. We want users to update libvirt without having to rewrite their app (or even rebuild it = ABI stability). And the commit broke that promise. It's only fair that it is reverted until proper solution is found. Michal
