On Thu, Jan 20, 2022 at 21:29 Michal Prívozník <mprivozn@xxxxxxxxxx> wrote:
On 1/20/22 16:48, Ani Sinha wrote:
>
>
>
> AKA kicking the can one more time 🙃
Well, I should have been more careful and not merge the patch in the
first place. Changing API behavior is something we should never do.
Looking at the code closer, it looks like all callers of this function
would need to ignore the reported error so that their behavior is not
changed. At this point, does it make sense to report an error in the
function?
The callers can decide what do with the error raised by the function. We should not write functions that cannot fail.
