Re: [PATCH 0/2 for 8.0] Update index after allocating port for isa-serial device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/13/22 15:43, Michal Prívozník wrote:
> On 1/13/22 08:33, Divya Garg wrote:
>> Issue
> 
>>
>> Divya Garg (2):
>>   Add the port allocation logic for isa-serial devices.
>>   qemu: add index for isa-serial device using target.port
> 
> 
>>  61 files changed, 156 insertions(+), 90 deletions(-)
>>
> 
> Hey, couple of points. Usually, when sending new version we do so in a
> new thread. And we don't CC random people. Us, developers, are
> subscribed to the list.
> 
> Anyway, I'm raising only very basic nitpicks with your patches. I'll
> squash in the fixes I'm suggesting before pushing. Speaking of which, we
> are currently in freeze, preparing for tomorrow's release. so I'll push
> these tomorrow.
> 
> Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> 

This is now pushed. Congratulations on your first libvirt contribution!

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux