On Thu, Jan 13, 2022 at 10:30 PM Divya Garg <divya.garg@xxxxxxxxxxx> wrote:
On 13/01/22 9:41 pm, Peter Krempa wrote:
On Thu, Jan 13, 2022 at 21:27:24 +0530, Ani Sinha wrote:On Thu, Jan 13, 2022 at 20:13 Michal Prívozník <mprivozn@xxxxxxxxxx> wrote:On 1/13/22 08:33, Divya Garg wrote:Speaking of which, weare currently in freeze, preparing for tomorrow's release. so I'll push these tomorrow.Shouldn’t the bug fix patch have been part of tomorrows release? I thought bug fixes can be merged even when there is a code freeze. Just trying to understand the process here.No, this change is too invasive IMO and Michal seems to think the same. The boundaries are not exact and it's up to the person commiting/approving the code to make the ultimative decision. But the gist is that you don't push into a RC something which might break the release.Hi ! Thankyou so much. So will you like me to post a new iteration, since
today has a code freeze anyway ? Or will it be okay to merge this change ?
Michal has already said he will push your change after the release tomorrow. At the same time he will fix things he was suggesting. So you can relax and wait for him to push. No need to churn out a new iteration.