On Sun, Oct 10, 2021 at 21:41:57 +0200, Peter Krempa wrote: > On Sat, Oct 09, 2021 at 15:55:54 +0800, dinglimin@xxxxxxxxxxxxxxxxxxxx wrote: > > From: dinglimin <dinglimin@xxxxxxxxxxxxxxxxxxxx> > > > > The BlockCopy command is designed to copy a chain of disk backup images to dest. > > For RBD external destination, before the modification, only the '--XML' parameter is supported by 'blockdev-mirror'. > > After the modification, the '--dest' parameter(--dest 'rbd:xxx/xxx:auth_supported=none:mon_host=xxx.xxx.xxx.xxx')can be used. > > > > Signed-off-by: dinglimin <dinglimin@xxxxxxxxxxxxxxxxxxxx> > > --- > > src/qemu/qemu_driver.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) [...] > > NACK, > > the correct approach is as you mention in the commit message is to use > the "--xml" parameter of 'virsh blockcopy' to pass a XML describing the > RBD destionation. > > We don't want to add a hack to do this via the --dest parameter. Use the > XML. > As a side note. If you want to implement syntax suggar to create the --xml argument for you via command line parameters you can add virsh command called 'virsh block-copy-as'. Take inspiration from 'virsh attach-disk-as' on how network disks are specified. Modifying the daemon code to accept this hack is not acceptable nevertheless.
