On Sat, Oct 09, 2021 at 15:55:54 +0800, dinglimin@xxxxxxxxxxxxxxxxxxxx wrote:
> From: dinglimin <dinglimin@xxxxxxxxxxxxxxxxxxxx>
>
> The BlockCopy command is designed to copy a chain of disk backup images to dest.
> For RBD external destination, before the modification, only the '--XML' parameter is supported by 'blockdev-mirror'.
> After the modification, the '--dest' parameter(--dest 'rbd:xxx/xxx:auth_supported=none:mon_host=xxx.xxx.xxx.xxx')can be used.
>
> Signed-off-by: dinglimin <dinglimin@xxxxxxxxxxxxxxxxxxxx>
> ---
> src/qemu/qemu_driver.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 760d30a..db15898 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -14963,12 +14963,27 @@ qemuDomainBlockCopyCommon(virDomainObj *vm,
> virStorageSource *mirrorBacking = NULL;
> g_autoptr(GHashTable) blockNamedNodeData = NULL;
> int rc = 0;
> + const char *p = NULL;
>
> /* Preliminaries: find the disk we are editing, sanity checks */
> virCheckFlags(VIR_DOMAIN_BLOCK_COPY_SHALLOW |
> VIR_DOMAIN_BLOCK_COPY_REUSE_EXT |
> VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB, -1);
>
> + /* if mirror->path contains 'rbd:' prefix, set rbd attributes */
> + if (STRPREFIX(mirror->path, "rbd:")) {
> + mirror->format = VIR_STORAGE_FILE_RAW;
> + mirror->protocol = VIR_STORAGE_NET_PROTOCOL_RBD;
> + mirror->type = VIR_STORAGE_TYPE_NETWORK;
> +
> + p = g_strdup(mirror->path);
> + if (virStorageSourceParseRBDColonString(p, mirror) < 0) {
> + virReportError(VIR_ERR_INVALID_ARG, "%s",
> + _("RBD path conversion failed"));
> + return -1;
> + }
> + }
NACK,
the correct approach is as you mention in the commit message is to use
the "--xml" parameter of 'virsh blockcopy' to pass a XML describing the
RBD destionation.
We don't want to add a hack to do this via the --dest parameter. Use the
XML.
