Only in the post-parse callback in the qemu driver, I switch it from "default" to "qemu".
Thus, if you don't call the post-parse on this test, then tests which use luks format fail.
Specifically:
network-qcow2-backing-chain-encryption_auth
file-qcow2-backing-chain-encryption
file-raw-luks
-----"Peter Krempa" <pkrempa@xxxxxxxxxx> wrote: -----
To: "Or Ozeri" <oro@xxxxxxxxxx>
From: "Peter Krempa" <pkrempa@xxxxxxxxxx>
Date: 10/06/2021 09:37AM
Cc: libvir-list@xxxxxxxxxx, idryomov@xxxxxxxxx, to.my.trociny@xxxxxxxxx, dannyh@xxxxxxxxxx
Subject: [EXTERNAL] Re: [PATCH v2 1/5] qemu: add disk post parse to qemublocktest
From: "Peter Krempa" <pkrempa@xxxxxxxxxx>
Date: 10/06/2021 09:37AM
Cc: libvir-list@xxxxxxxxxx, idryomov@xxxxxxxxx, to.my.trociny@xxxxxxxxx, dannyh@xxxxxxxxxx
Subject: [EXTERNAL] Re: [PATCH v2 1/5] qemu: add disk post parse to qemublocktest
On Tue, Oct 05, 2021 at 09:41:12 -0500, Or Ozeri wrote:
> The post parse callback is part of the real (non-test) processing flow.
> This commit adds it (for disks) to the qemublocktest flow as well.
Could you please elaborate why this is needed? Specifically
qemublocktest takes a few liberties from the "real" code flow since we
need to fake a lot of stuff. E.g. see testQemuDiskXMLToJSONFakeSecrets.
Specifically I didn't see anything in your patches [1] which would add
anything to the post parse callback.
[1] Well after my crude rebase of the series. What you've posted didn't
apply neither on master nor on the last release. I had to go one version
back and it had conflicts which I didn't spend much time thinking about.
> The post parse callback is part of the real (non-test) processing flow.
> This commit adds it (for disks) to the qemublocktest flow as well.
Could you please elaborate why this is needed? Specifically
qemublocktest takes a few liberties from the "real" code flow since we
need to fake a lot of stuff. E.g. see testQemuDiskXMLToJSONFakeSecrets.
Specifically I didn't see anything in your patches [1] which would add
anything to the post parse callback.
[1] Well after my crude rebase of the series. What you've posted didn't
apply neither on master nor on the last release. I had to go one version
back and it had conflicts which I didn't spend much time thinking about.
