Re: [PATCH v2 1/5] qemu: add disk post parse to qemublocktest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 05, 2021 at 09:41:12 -0500, Or Ozeri wrote:
> The post parse callback is part of the real (non-test) processing flow.
> This commit adds it (for disks) to the qemublocktest flow as well.

Could you please elaborate why this is needed? Specifically
qemublocktest takes a few liberties from the "real" code flow since we
need to fake a lot of stuff. E.g. see testQemuDiskXMLToJSONFakeSecrets.

Specifically I didn't see anything in your patches [1] which would add
anything to the post parse callback.


[1] Well after my crude rebase of the series. What you've posted didn't
apply neither on master nor on the last release. I had to go one version
back and it had conflicts which I didn't spend much time thinking about.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux