On Mon, 27 Sep 2021, Ján Tomko wrote:
> On a Monday in 2021, Ani Sinha wrote:
> > The following change in qemu added support for a global boolean flag
> > specific
> > to i440fx machines that would turn off or on acpi based hotplug for pci root
> > bus:
> >
> > 3d7e78aa7777f ("Introduce a new flag for i440fx to disable PCI hotplug on
> > the root bus")
> >
> > The option is passed as "-global PIIX4_PM.acpi-root-pci-hotplug=on" etc in
> > qemu
> > commandline. It is enabled by default. This patch adds the corresponding
> > qemu
> > capabilities in libvirt as QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG.
> >
> > Please note that the test specific qemu capabilities .replies files has
> > already
> > been updated as a part of regular refreshing them when a new qemu version is
> > released. Hence, no updates to those files are required.
> >
> > Signed-off-by: Ani Sinha <ani@xxxxxxxxxxx>
> > Reviewed-by: Laine Stump <laine@xxxxxxxxxx>
> > ---
> > src/qemu/qemu_capabilities.c | 4 ++++
> > src/qemu/qemu_capabilities.h | 3 +++
> > tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 1 +
> > tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
> > 5 files changed, 10 insertions(+)
> >
> > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> > index db5432c9fc..71aca20c4c 100644
> > --- a/src/qemu/qemu_capabilities.c
> > +++ b/src/qemu/qemu_capabilities.c
> > @@ -639,6 +639,9 @@ VIR_ENUM_IMPL(virQEMUCaps,
> > "s390-pv-guest", /* QEMU_CAPS_S390_PV_GUEST */
> > "set-action", /* QEMU_CAPS_SET_ACTION */
> > "virtio-blk.queue-size", /* QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE */
> > +
> > + /* 410 */
> > + "piix4-acpi-root-hotplug-en", /*
> > QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG */
>
> What does "en" stand for?
en stands for "enable"
>
> "piix4.acpi-root-hotplug" (with the dot) would give a rough idea what
> property of what device is being probed (even though neither the
> "device" name nor the property name is exact in my example)
>
OK for this one I will wait and see what Laine thinks. Its a trivial
change.
