On Tue, Aug 17, 2021 at 12:06:11PM +0200, Martin Kletzander wrote:
> On Tue, Aug 17, 2021 at 11:26:42AM +0200, Pavel Hrdina wrote:
> > Based on kernel commit messages the interface is
> >
> > /sys/class/fc/fc_udev_device/appid_store
> >
> > where we need to write the following string "$INODE:$APPID".
> >
> > $INODE is the VM root cgroup inode in hexadecimal and $APPID is user
> > provided string that will be attached to each FC frame for the VM
> > within the cgroup identified by inode and has limit 128 bytes.
> >
> > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> > ---
> > src/qemu/qemu_cgroup.c | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> > index f2d99abcfa..cb83cc8e3e 100644
> > --- a/src/qemu/qemu_cgroup.c
> > +++ b/src/qemu/qemu_cgroup.c
> > @@ -904,6 +904,30 @@ qemuSetupCpuCgroup(virDomainObj *vm)
> > }
> >
> >
> > +static int
> > +qemuSetupCgroupAppid(virDomainObj *vm)
> > +{
> > + qemuDomainObjPrivate *priv = vm->privateData;
> > + int inode = virCgroupGetInode(priv->cgroup);
>
> You are not checking if this resulted in an error.
Nice catch, somehow missed that! Will fix, thanks.
Attachment:
signature.asc
Description: PGP signature
