Re: [libvirt PATCH v3 0/5] add support for Fibre Channel VMID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 17, 2021 at 11:26:37AM +0200, Pavel Hrdina wrote:
changes in v3:
   - rename the XML attribute to appid as technically what user
     provides is not VMID, that is created by kernel

changes in v2:
   - refactor of resource parsing and formatting code
   - use <fibrechannel vmid=''/> element
   - use stat() directly
   - report only single system error

Pavel Hrdina (5):
 vircgroup: introduce virCgroupGetInode function
 conf: refactor virDomainResourceDefParse
 conf: refactor virDomainResourceDefFormat
 conf: introduce support for Fibre Channel VMID
 qemu: implement support for Fibre Channel VMID


After the obvious fix in PATCH 5/5 and question answered in 4/5 the
series is

Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

docs/formatdomain.rst                         | 21 ++++++++++
docs/schemas/domaincommon.rng                 | 21 ++++++++--
src/conf/domain_conf.c                        | 42 +++++++++++--------
src/conf/domain_conf.h                        |  1 +
src/conf/domain_validate.c                    | 19 +++++++++
src/libvirt_private.syms                      |  1 +
src/qemu/qemu_cgroup.c                        | 27 ++++++++++++
src/util/vircgroup.c                          | 31 ++++++++++++++
src/util/vircgroup.h                          |  2 +
.../fibrechannel-appid.xml                    | 21 ++++++++++
tests/genericxml2xmltest.c                    |  2 +
11 files changed, 167 insertions(+), 21 deletions(-)
create mode 100644 tests/genericxml2xmlindata/fibrechannel-appid.xml

--
2.31.1

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux