On Tue, May 25, 2021 at 11:36:59AM -0500, Jonathon Jongsma wrote: > On Tue, 2021-05-25 at 11:20 +0100, Daniel P. Berrangé wrote: > > On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote: > > > This is a short patch series based on an initial patch from Boris > > > Fiuczynski > > > that I massaged a little bit and added a few additional patches. > > > > > > This allows you to define mediated devices in libvirt which are > > > started > > > automatically at boot or parent device plugin. > > > > Sorry I missed review of this series before it was merged, but I > > think > > this design aproach is seriously wrong. This is exposing autostart as > > an XML property, but in all other parts of libvirt we expose > > autostart > > as an explicit API. I think we need to make the implemnentation > > consistent with the rest of libvirt. > > Hmm, you're right. Sorry I didn't catch that. Should we revert these > patches for now then? I'll try to come up with a new implementation. Several of the patches are still useful. Only the 2nd patch and some files in the 3rd are impacted I think. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
