On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote: > This is a short patch series based on an initial patch from Boris Fiuczynski > that I massaged a little bit and added a few additional patches. > > This allows you to define mediated devices in libvirt which are started > automatically at boot or parent device plugin. Sorry I missed review of this series before it was merged, but I think this design aproach is seriously wrong. This is exposing autostart as an XML property, but in all other parts of libvirt we expose autostart as an explicit API. I think we need to make the implemnentation consistent with the rest of libvirt. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
