On Wed, Mar 03, 2010 at 11:51:26AM -0500, Dave Allan wrote: > On 03/02/2010 06:46 PM, Eric Blake wrote: > >According to David Allan on 3/2/2010 3:13 PM: > >>--- > >> tools/virsh.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > >> 1 files changed, 42 insertions(+), 0 deletions(-) > >> > >>diff --git a/tools/virsh.c b/tools/virsh.c > >>index a6a637d..e52b011 100644 > >>--- a/tools/virsh.c > >>+++ b/tools/virsh.c > >>@@ -5221,6 +5221,47 @@ cmdVolDelete(vshControl *ctl, const vshCmd *cmd) > >> > >> > >> /* > >>+ * "vol-zero-out" command > >>+ */ > >>+static const vshCmdInfo info_vol_zero_out[] = { > >>+ {"help", gettext_noop("zero out a vol")}, > >>+ {"desc", gettext_noop("Ensure further reads from a volume return > >>zeroes.")}, > > > >Unrelated to your patch, but is there any reason we don't use N_() as the > >idiomatic counterpart to _(), rather than spelling out gettext_noop > >everywhere? > > > > I assume inertia, but someone else may have a better answer. Historical accident :-) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list