On Fri, Apr 09, 2021 at 04:32:55PM -0500, Jonathon Jongsma wrote: > Erik recommended several changes to the mdev series that was just merged and > suggested to address them in a follow-up patch series. They're mostly related > to simplifying the testing, and shouldn't actually change any behavior (aside > from switching to using the long commandline options when executing mdevctl). > > Erik Skultety (4): > nodedev: driver: Swap virMdevctlStart and virMdevctlCreate > nodedev: driver: Introduce internal mdevctl commands enum > nodedev: driver: Create a generic mdevctl command translator > tests: nodedev: Make the mdevctl test function and helper generic > > Jonathon Jongsma (7): > nodedev: don't log error in nodeDeviceFindAddressByName() > nodedev: avoid use of VIR_ERR_NO_* errors internally > tests: nodedev: switch all test macros to accept a filename > nodedev: Switch to using long options for mdevctl > nodedev: Remove GetMdevctl*Command() wrappers > tests: nodedev: simplify test macros > tests: nodedev: remove unused variable This fails to apply: Applying: tests: nodedev: Make the mdevctl test function and helper generic error: sha1 information is lacking or useless (tests/nodedevmdevctltest.c). error: could not build fake ancestor Patch failed at 0009 tests: nodedev: Make the mdevctl test function and helper generic There were a bunch of other merge conflicts even before this patch, so please respin a rebased version. Regards Erik