Erik recommended several changes to the mdev series that was just merged and
suggested to address them in a follow-up patch series. They're mostly related
to simplifying the testing, and shouldn't actually change any behavior (aside
from switching to using the long commandline options when executing mdevctl).
Erik Skultety (4):
nodedev: driver: Swap virMdevctlStart and virMdevctlCreate
nodedev: driver: Introduce internal mdevctl commands enum
nodedev: driver: Create a generic mdevctl command translator
tests: nodedev: Make the mdevctl test function and helper generic
Jonathon Jongsma (7):
nodedev: don't log error in nodeDeviceFindAddressByName()
nodedev: avoid use of VIR_ERR_NO_* errors internally
tests: nodedev: switch all test macros to accept a filename
nodedev: Switch to using long options for mdevctl
nodedev: Remove GetMdevctl*Command() wrappers
tests: nodedev: simplify test macros
tests: nodedev: remove unused variable
src/node_device/node_device_driver.c | 181 ++++++++---------
src/node_device/node_device_driver.h | 43 ++--
...19_36ea_4111_8f0a_8c9a70e21366-create.argv | 2 +
...9_36ea_4111_8f0a_8c9a70e21366-create.json} | 0
...19_36ea_4111_8f0a_8c9a70e21366-define.argv | 2 +-
...019_36ea_4111_8f0a_8c9a70e21366-start.argv | 3 +-
...d019_36ea_4111_8f0a_8c9a70e21366-stop.argv | 1 +
..._36ea_4111_8f0a_8c9a70e21366-undefine.argv | 1 +
...39_495e_4243_ad9f_beb3f14c23d9-create.argv | 1 +
...9_495e_4243_ad9f_beb3f14c23d9-create.json} | 0
...39_495e_4243_ad9f_beb3f14c23d9-define.argv | 2 +-
...d39_495e_4243_ad9f_beb3f14c23d9-start.argv | 1 -
...16_1ca8_49ac_b176_871d16c13076-create.argv | 1 +
...6_1ca8_49ac_b176_871d16c13076-create.json} | 0
...16_1ca8_49ac_b176_871d16c13076-define.argv | 2 +-
...916_1ca8_49ac_b176_871d16c13076-start.argv | 1 -
tests/nodedevmdevctldata/mdevctl-create.argv | 1 -
tests/nodedevmdevctldata/mdevctl-stop.argv | 1 -
.../nodedevmdevctldata/mdevctl-undefine.argv | 1 -
tests/nodedevmdevctltest.c | 192 ++++++------------
20 files changed, 174 insertions(+), 262 deletions(-)
create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9=
a70e21366-create.argv
rename tests/nodedevmdevctldata/{mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-s=
tart.json =3D> mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-create.json} (100%)
create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9=
a70e21366-stop.argv
create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9=
a70e21366-undefine.argv
create mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb=
3f14c23d9-create.argv
rename tests/nodedevmdevctldata/{mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-s=
tart.json =3D> mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-create.json} (100%)
delete mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb=
3f14c23d9-start.argv
create mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871=
d16c13076-create.argv
rename tests/nodedevmdevctldata/{mdev_fedc4916_1ca8_49ac_b176_871d16c13076-s=
tart.json =3D> mdev_fedc4916_1ca8_49ac_b176_871d16c13076-create.json} (100%)
delete mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871=
d16c13076-start.argv
delete mode 100644 tests/nodedevmdevctldata/mdevctl-create.argv
delete mode 100644 tests/nodedevmdevctldata/mdevctl-stop.argv
delete mode 100644 tests/nodedevmdevctldata/mdevctl-undefine.argv
--=20
2.26.3
