According to Daniel Veillard on 3/2/2010 9:53 AM: >>> +#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE) >> >> Redundant parenthesis. I know upstream gnulib's maint.mk warns about >> them; did we turn them off in libvirt's 'make syntax-check'? > > Hum, what's redundant here ? It's perfectly acceptable (and less typing) to do: #if defined HAVE_POSIX_FALLOCATE && !defined HAVE_FALLOCATE Whether it is also more legible is a matter of opinion. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list