Re: [libvirt PATCH v4 5/6] ci: util: Add a registry checker for stale images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 18, 2021 at 05:32:14PM +0100, Andrea Bolognani wrote:
> On Thu, 2021-03-18 at 17:11 +0100, Erik Skultety wrote:
> > +            msg = textwrap.dedent(f"""
> > +                The following images are stale and can be purged from the registry:
> > +
> > +                    STALE_DETAILS
> > +
> > +                You can delete the images listed above using this shell snippet:
> > +
> > +                    $ for image_id in {stale_ids}; do
> > +                        curl --request DELETE --header "PRIVATE-TOKEN: <access_token>" \\
> > +                            {registry_uri}/$image_id;
> 
> There should be one additional leading space here, to align things
> better.
> 
> Please also move the check_stale_image() function after the
> refresh_cirrus() image - basically all action_*() functions should
> continue being grouped together.
> 
> With those tweaks,
> 
>   Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

The series is now merged. Thank you for review. Now, since you're one of the
repo owners in GitLab, would you mind purging the old images? :)

Erik




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux