On Fri, 2021-03-19 at 11:36 +0100, Erik Skultety wrote: > On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote: > > On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote: > > > As documented at [1], the common practice wrt to private > > > > s/wrt to/with respect to/ > > > > > def parse(self): > > > return self.parser.parse_args() > > > > Shouldn't this change be applied to Parser.parser... > > > > > def run(self): > > > self.args.func(self) > > > > ... and Application.args too? > > > > Everything else looks good. > > May I assume your R-b for this patch after having resolved this in v4? Sure thing! I thought I had sent an explicit one, but it looks like I failed to do so after all O:-) -- Andrea Bolognani / Red Hat / Virtualization
