On Thu, 2021-03-11 at 14:44 +0000, Daniel P. Berrangé wrote: > On Thu, Mar 11, 2021 at 03:32:23PM +0100, Andrea Bolognani wrote: > > Mh, fair enough. I guess we can drop > > > > BuildRequires: make > > > > from our .spec files then... I'll post a patch right away. > > Our RPMs build with a .git present, so they'll run syntax-checks even > downstream. We explicitly disable syntax-check: https://gitlab.com/libvirt/libvirt/-/blob/f11f32326f163dda28143e9495d9bbc5d4869f6d/libvirt.spec.in#L1301-1304 The MinGW spec doesn't have a %check section at all, for obvious reasons. Patch here: https://listman.redhat.com/archives/libvir-list/2021-March/msg00526.html -- Andrea Bolognani / Red Hat / Virtualization
