On Wed, Feb 24, 2021 at 02:36:46PM +0100, Thomas Huth wrote: > On 24/02/2021 14.11, Daniel P. Berrangé wrote: > > The VNC ACL concept has been replaced by the pluggable "authz" framework > > which does not use monitor commands. > > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx> > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > docs/system/deprecated.rst | 16 --- > > docs/system/removed-features.rst | 13 +++ > > hmp-commands.hx | 76 ------------- > > monitor/misc.c | 187 ------------------------------- > > ui/vnc.c | 38 ------- > > 5 files changed, 13 insertions(+), 317 deletions(-) > > If I run: > > grep -r vnc.*acl * > > I also see some lines in tests/check-block-qdict.c ... are they related and > should be removed, too? Yes & no. This test is using the vnc ACL syntax as example input for validating the qdict parsing, but isn't functionally connected to the actual VNC ACL impl. > Apart from that, patch looks fine to me: > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
