Re: [PATCH 01/14] ui, monitor: remove deprecated VNC ACL option and HMP commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/02/2021 14.11, Daniel P. Berrangé wrote:
The VNC ACL concept has been replaced by the pluggable "authz" framework
which does not use monitor commands.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx>
Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
  docs/system/deprecated.rst       |  16 ---
  docs/system/removed-features.rst |  13 +++
  hmp-commands.hx                  |  76 -------------
  monitor/misc.c                   | 187 -------------------------------
  ui/vnc.c                         |  38 -------
  5 files changed, 13 insertions(+), 317 deletions(-)

If I run:

 grep -r vnc.*acl *

I also see some lines in tests/check-block-qdict.c ... are they related and should be removed, too?

Apart from that, patch looks fine to me:
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux