On Mon, Feb 15, 2021 at 11:19:12 +0100, Erik Skultety wrote: > On Mon, Feb 15, 2021 at 11:10:43AM +0100, Peter Krempa wrote: > > On Mon, Feb 15, 2021 at 10:59:47 +0100, Andrea Bolognani wrote: > > > After the recent fixes, it's now confirmed to work. > > > > > > https://gitlab.com/libvirt/libvirt/-/issues/121 > > > > Should it be closed then? > > Good point, we should start using the "magic" keywords that GitLab recognizes > an closes issues automatically. Or just close it manually after the person confirms that it's fixed. In cases such as this you don't want to close the issue with a push-event if you can't test that the patches indeed fix the issue.