On Thu, Jan 14, 2021 at 14:39:42 +0100, Michal Privoznik wrote: > On 1/14/21 2:10 PM, Peter Krempa wrote: > > On Thu, Jan 14, 2021 at 13:52:45 +0100, Peter Krempa wrote: > > > On Thu, Jan 14, 2021 at 13:37:23 +0100, Michal Privoznik wrote: > > > > This capability tracks whether memory-backend-file has > > > > "x-use-canonical-path-for-ramblock-id" attribute. Introduced into > > > > QEMU by commit fa0cb34d2210cc749b9a70db99bb41c56ad20831. While > > > > "x-" prefix is considered experimental or internal to QEMU, the > > > > next commit justifies its use. > > > > > > Since the detection of this feature is not limited to existing qemus, my > > > requirement that qemu must add acknowledgement that > > > "x-use-canonical-path-for-ramblock-id" will be treated as a stable > > > feature from now on and the qemu commit adding that must be mentioned in > > > this commit. > > Is there something concrete you have on mind that you want me to write > there? I thought I added a comment around capability detection that > justifies its use. I've responded to the qemu patch, since I don't consider the wording binding enough: https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg03288.html Once that change is done: Commit message should be more explicit: This capability tracks whether memory-backend-file has "x-use-canonical-path-for-ramblock-id" attribute. Introduced into QEMU by commit fa0cb34d2210cc749b9a70db99bb41c56ad20831. As of QEMU commit $HASH the property is considered stable by qemu despite the 'x-' prefix to preserve compatibility with released qemu versions. And the comment added to the code should be more factual: /* As of QEMU commit $HASH the "x-use-canonical-path-for-ramblock-id" * property is considered stable and supported. The 'x-' prefix was kept * for compatibility with already released qemu versions. */
