On Thu, Jan 14, 2021 at 12:50:49PM +0100, Andrea Bolognani wrote: > On Thu, 2021-01-14 at 12:03 +0100, Erik Skultety wrote: > > rules: > > + - if: "$JOB_TEMPORARY_DISABLED" > > + allow_failure: true > [...] > > rules: > > + - if: "$TEMPORARY_DISABLE" > > + allow_failure: true > [...] > > rules: > > + - if: "$TEMPORARY_DISABLED" > > + allow_failure: true > > Please pick *one* name and stick to it. > > I recommend either "TEMPORARILY_DISABLED" or > "JOB_TEMPORARILY_DISABLED", with the order in which I've listed them > reflecting my preference. > > You also need to add these rules: to .container_job_template, since > temporarily disabling specific container builds is a valid use case. I wasn't sure with this one, but now that I remember the very recent case with CentOS breaking the backwards compatibility with the changed powertools repo name, you're right, indeed it is desirable to add it there as well. Regards, Erik
