Re: [libvirt PATCH v2 3/3] gitlab-ci.yml: Add an explicit env variable to mark a job as broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2021-01-14 at 12:03 +0100, Erik Skultety wrote:
>    rules:
> +    - if: "$JOB_TEMPORARY_DISABLED"
> +      allow_failure: true
[...]
>    rules:
> +    - if: "$TEMPORARY_DISABLE"
> +      allow_failure: true
[...]
>    rules:
> +    - if: "$TEMPORARY_DISABLED"
> +      allow_failure: true

Please pick *one* name and stick to it.

I recommend either "TEMPORARILY_DISABLED" or
"JOB_TEMPORARILY_DISABLED", with the order in which I've listed them
reflecting my preference.

You also need to add these rules: to .container_job_template, since
temporarily disabling specific container builds is a valid use case.

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux