On Mon, Nov 09, 2020 at 09:31:09AM -0500, Matt Coleman wrote: > > On Nov 9, 2020, at 9:28 AM, Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: > > > > I was expecting to see that this patch only dropped code, but > > this is introducing a new v2 class. I think that ought to be > > down as a separate patch. Likewise for similar changes below. > > This is not actually adding a new class: current code accesses it via > data.common. So, this change is necessary in order to remove the v1 > version while leaving the v2 functionality intact. That doesn't seem to be the case. If I modify this patch so that it only removes the Msvm_XXXX classes for v1, everything still compiles. What's leftover is addition of 2 extra classes whcih don't seem to impact the build +class v2/Msvm_ResourceAllocationSettingData + string InstanceID + string Caption + string Description + string ElementName + uint16 ResourceType + string OtherResourceType + string ResourceSubType + string PoolID + uint16 ConsumerVisibility + string HostResource[] + string AllocationUnits + uint64 VirtualQuantity + uint64 Reservation + uint64 Limit + uint32 Weight + boolean AutomaticAllocation + boolean AutomaticDeallocation + string Parent + string Connection[] + string Address + uint16 MappingBehavior + string AddressOnParent + string VirtualQuantityUnits + string VirtualSystemIdentifiers[] +end + + +class v2/Msvm_SyntheticEthernet + string InstanceID + string Caption + string Description + string ElementName + uint16 ResourceType + string OtherResourceType + string ResourceSubType + string PoolID + uint16 ConsumerVisibility + string HostResource[] + string AllocationUnits + uint64 VirtualQuantity + uint64 Reservation + uint64 Limit + uint32 Weight + boolean AutomaticAllocation + boolean AutomaticDeallocation + string Parent + string Connection[] + string Address + uint16 MappingBehavior + string AddressOnParent + string VirtualQuantityUnits + uint16 DesiredVLANEndpointMode + string OtherEndpointMode + string VirtualSystemIdentifiers[] + boolean DeviceNamingEnabled + boolean AllowPacketDirect + boolean StaticMacAddress + boolean ClusterMonitored +end Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
