On Mon, Nov 09, 2020 at 03:43:07AM -0500, Matt Coleman wrote: > Signed-off-by: Matt Coleman <matt@xxxxxxxxx> > --- > src/hyperv/hyperv_wmi_generator.input | 424 +------------------------- > 1 file changed, 12 insertions(+), 412 deletions(-) > > diff --git a/src/hyperv/hyperv_wmi_generator.input b/src/hyperv/hyperv_wmi_generator.input > index 1377138a12..e6b53bc021 100644 > --- a/src/hyperv/hyperv_wmi_generator.input > +++ b/src/hyperv/hyperv_wmi_generator.input > > - > -class Msvm_ResourceAllocationSettingData > +class v2/Msvm_ResourceAllocationSettingData > + string InstanceID > string Caption > string Description > - string InstanceID > string ElementName > uint16 ResourceType > string OtherResourceType > @@ -865,64 +623,16 @@ class Msvm_ResourceAllocationSettingData > string Connection[] > string Address > uint16 MappingBehavior > + string AddressOnParent > + string VirtualQuantityUnits > string VirtualSystemIdentifiers[] > end I was expecting to see that this patch only dropped code, but this is introducing a new v2 class. I think that ought to be down as a separate patch. Likewise for similar changes below. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|