On Tue, 6 Oct 2020 08:58:36 +0200 Ján Tomko <jtomko@xxxxxxxxxx> wrote: > Recently, I have spent some time trying to figure out what this > function does. Let me share that with you before I forget. > > Ján Tomko (14): > qemu: agent: remove redundant checks > qemu: agent: split out qemuAgentGetInterfaceOneAddress > qemu: agent: remove impossible errors > qemu: agent: reduce scope of addrs_count > qemu: agent: expand addrs upfront > qemu: agent: use g_auto for ifname > qemu: agent: use virHashNew > qemu: agent: simplify access to ifaces_ret > qemu: agent: split out qemuAgentGetInterfaceAddresses > qemu: agent: use GetArray to remove a check > qemu: agent: use g_auto in qemuAgentGetInterfaces > qemu: agent: remove cleanup in qemuAgentGetInterfaces > qemuAgentGetInterfaceAddresses: turn ifname into char* > qemu: agent: rename tmp_iface to iface_obj > > src/qemu/qemu_agent.c | 291 > +++++++++++++++++++----------------------- 1 file changed, 134 > insertions(+), 157 deletions(-) > Aside from the patches I commented on (2,5,9), the others look good to me. Reviewed-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
