Re: [libvirt PATCH 6/9] spec: Move _vpath_builddir definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
>
> It belongs before package-specific feature flags are defined.
>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  libvirt.spec.in | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 2401404008..d8f689e651 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -12,6 +12,11 @@
>      %define supported_platform 0
>  %endif
>
> +# On RHEL 7 and older macro _vpath_builddir is not defined.
> +%if 0%{?rhel} && 0%{?rhel} <= 7
> +    %define _vpath_builddir %{_target_platform}
> +%endif
> +
>  # The hypervisor drivers that run in libvirtd
>  %define with_qemu          0%{!?_without_qemu:1}
>  %define with_lxc           0%{!?_without_lxc:1}
> @@ -31,11 +36,6 @@
>      %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x
>  %endif
>
> -# On RHEL 7 and older macro _vpath_builddir is not defined.
> -%if 0%{?rhel} && 0%{?rhel} <= 7
> -    %define _vpath_builddir %{_target_platform}
> -%endif
> -
>  %ifarch %{qemu_kvm_arches}
>      %define with_qemu_kvm      %{with_qemu}
>  %else
> --
> 2.26.2
>

Do we still need this anymore? Meson in EPEL 7 works without this definition...

But otherwise...

Reviewed-by: Neal Gompa <ngompa13@xxxxxxxxx>


-- 
真実はいつも一つ!/ Always, there's only one truth!





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux